Like most of the midwest, if you don't like the weather in Rapid City, all you have to do is wait a minute, and it will change.
Best months are June - September. Unless you're a winter sports fan and plan to spend time skiing in the northern Black Hills snowmobiling southern Black Hills and or just gambling in Deadwood, I would recommend against visiting in the winter.